[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Add FSP 2.2 specific support

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41728 )

Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... 
File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... 
PS3, Line 41: fsp_handle_reset(status);
> Ack

FSP requests System reset through "status" (return value) is not an error scenario. It can be due to the modified register settings take effect only post-reset. So, I suggest triggering system reset should be handled in the outside of function.
If FSP's reset request is considered as an error, then it should be handled differently like  triggering system recovery to avoid back to back resets!