Attention is currently required from: Martin L Roth.
Matt DeVillier has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87201?usp=email )
Change subject: Documentation: Add chip operations
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I think this is a great start. My only quarrel would be that it reads like chip_ops only exist at the SoC/chipset or mainboard level, and ignores their use in devicetree drivers. I'd have to think about how to best integrate that part though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87201?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5373eab2de2e255f9e3576794b9ad02d9711a6c2
Gerrit-Change-Number: 87201
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Fri, 11 Apr 2025 14:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes