Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad. ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@7 PS6, Line 7: mb/google/volteer/variants/volteer:Tune
Please add the space *after* the colon back. […]
Fixed in Mark’s patch set.
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@8 PS6, Line 8:
Describe the problem: […]
Fixed in Mark’s patch set.
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@10 PS6, Line 10: to bring the bus frequency closer to 400kHz.
Space after comma: […]
Fixed in Mark’s patch set.
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG@18 PS7, Line 18: Signed-off-by:Johnny Li johnny_li@wistron.corp-partner.google.com Please add a space after the colon. (This build bot complains about a missing Signed-off-by line.)