Attention is currently required from: Subrata Banik, Christian Walter, Meera Ravindranath, Angel Pons, Lean Sheng Tan.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61528 )
Change subject: mb/intel/adlrvp: Fix vbt loading error
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/intel/adlrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/61528/comment/786d70fe_68bba1fa
PS2, Line 70: const char *mainboard_vbt_filename(void)
thanks Subrata. Done. […]
@Sheng, chrome emerge has ability to add multiple files into CBFS using CBFS commands just before signing the image. Issue here is we can't statically decide how many VBT files we need to have during coreboot build.
so as Nico pointed out, we may need to use site-local to overcome this issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f6f9554b75f4d62198aac9938e65c71c3e7cee9
Gerrit-Change-Number: 61528
Gerrit-PatchSet: 4
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 03 Feb 2022 12:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment