Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44078 )
Change subject: Revert "device/pci_device.c: Do not complain about disabled devices" ......................................................................
Revert "device/pci_device.c: Do not complain about disabled devices"
This reverts commit ad247ac5d8ef4a38bd1d61fbd28076f343a46c5c.
It doesn't work like this. The `dev->enable` field has already been updated and is always `0` at this point.
Change-Id: I5b3560dcea2f226c841f4823526db2fdab149d22 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44078 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/device/pci_device.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index f3cced9..3623c3b 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1297,10 +1297,6 @@ /* Unlink it from list. */ *prev = dev->sibling;
- /* If disabled in devicetree, do not print any messages. */ - if (!dev->enabled) - continue; - if (!once++) printk(BIOS_WARNING, "PCI: Leftover static devices:\n"); printk(BIOS_WARNING, "%s\n", dev_path(dev));