7 Mar
2022
7 Mar
'22
7:52 a.m.
Attention is currently required from: Felix Singer, Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62629 )
Change subject: soc/intel/alderlake: Allow mainboard to configure C state auto-demotion ......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/62629/comment/f7464bd1_54aab865 PS4, Line 572: DisableC1StateAutoDemotion
Yes Subrata...I just wanted to align with syntax in entire file. Let me push another patch correcting entire file, is that okay?
Sure. SGTM
--
To view, visit https://review.coreboot.org/c/coreboot/+/62629
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d7839d8fecd7b5403f52f3926d1d0bc06728ed9
Gerrit-Change-Number: 62629
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-CC: Vinay Kumar vinay.kumar@intel.com
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 07:52:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-MessageType: comment