Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37792 )
Change subject: {drivers,soc}/intel/fsp2_0: Move chipset specific logo handling to SoC
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/lo...
File src/drivers/intel/fsp2_0/logo.c:
https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/lo...
PS4, Line 29: if (logo_size)
: *logo_ptr = (UINT32)logo_buffer;
Ok, this is what I said for a invalid logo instance we can remove the cbmem entry here itself and se […]
It is of course possible to do this but the benefit is marginal as the cbmem entry will be removed directly after the fsp call.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30c7bdc0532ff8823e06f4136f210b542385d5ce
Gerrit-Change-Number: 37792
Gerrit-PatchSet: 6
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Dec 2019 12:24:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment