Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42057 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Fix in-circuit programming
......................................................................
Patch Set 1: Code-Review+2
We should define somewhere how these tables are to be
interpreted. For this one "In circuit flashing" I would
argue that it's meaningless if we would set to Yes for
everything that works by chance. But I also wonder about
"Internal flashing" does that mean you can flash from
vendor? or just that a (flashrom) driver exists?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If422810e84355cb94004e5ca2b95d239804699d2
Gerrit-Change-Number: 42057
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 06 Jun 2020 10:27:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment