Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )
Change subject: mb/lenovo/x200: Add support for ThinkLight
......................................................................
Patch Set 2:
(1 comment)
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a...
File src/mainboard/lenovo/x200/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a...
PS1, Line 60: }
I guess some refactoring in common/shared code with all the Lenovo ThinkPads would be nice.
I think I could move it to ec/lenovo/h8/acpi/ec.asl instead, that way all the ThinkPads would benefit, but I can't really test it on any non-X20x models.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65
Gerrit-Change-Number: 40620
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Apr 2020 10:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment