8 Jan
2021
8 Jan
'21
5:11 a.m.
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49136 )
Change subject: mb/intel/adlrvp: Fix wrong comments and typo ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49136/comment/4a055a81_40f44fb8 PS2, Line 74: Enable CPU PCIE PEG Slot 1 and 2
IMHO, it would make more sense to change the comments in the same patch that enables the correspondi […]
Sure on it. let me try to update the CL by EOD
--
To view, visit https://review.coreboot.org/c/coreboot/+/49136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92123450bd7cfb2e70aae8de03053672a7772451
Gerrit-Change-Number: 49136
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 08 Jan 2021 12:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment