Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )
Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability() ......................................................................
Patch Set 18:
(16 comments)
https://review.coreboot.org/c/coreboot/+/30826/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/30826/9//COMMIT_MSG@15 PS9, Line 15: TPML_DIGEST_VALUE pointer as input argument.
I think my main question here is still... […]
Done
https://review.coreboot.org/c/coreboot/+/30826/8/src/security/tpm/tspi/tspi.... File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/c/coreboot/+/30826/8/src/security/tpm/tspi/tspi.... PS8, Line 209: TPML_DIGEST_VALUES tpml_digests;
move down to the second statement
Done
https://review.coreboot.org/c/coreboot/+/30826/9/src/security/tpm/tspi/tspi.... File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/c/coreboot/+/30826/9/src/security/tpm/tspi/tspi.... PS9, Line 212: #if CONFIG(TPM2)
Use […]
Done
https://review.coreboot.org/c/coreboot/+/30826/6/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/30826/6/src/security/tpm/tss.h@195 PS6, Line 195: uint32_t tlcl_extend(int pcr_num, const TPML_DIGEST_VALUES *in_digests,
need consistent spacing around '*' (ctx:WxV)
Done
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss.h@73 PS5, Line 73: void *tpm_process_command(TPM_CC command, void *command_body, size_t *response_size);
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/tcg-1.... File src/security/tpm/tss/tcg-1.2/tss.c:
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/tcg-1.... PS5, Line 355: switch (in_digests[0].hashAlg)
that open brace { should be on the previous line
Done
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss/tcg-2.... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss/tcg-2.... PS4, Line 237: if (in_digests->digests[0].hashAlg == TPM_ALG_ERROR) {
Please use && for this sort of stuff, not 4 levels of nesting.
Done
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/tcg-2.... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/tcg-2.... PS5, Line 417: response = tpm_process_command(TPM2_GetCapability, &cmd, &response_size);
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/6/src/security/tpm/tss/tcg-2.... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/30826/6/src/security/tpm/tss/tcg-2.... PS6, Line 151: memcpy((void *) pcr_ext_cmd.digests.digests[i].digest.sha1,
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/6/src/security/tpm/tss/tcg-2.... PS6, Line 156: memcpy((void *) pcr_ext_cmd.digests.digests[i].digest.sha256,
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/6/src/security/tpm/tss/tcg-2.... PS6, Line 424: response = tpm_process_command(TPM2_GetCapability, &cmd, &response_size);
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/7/src/security/tpm/tss/tcg-2.... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/30826/7/src/security/tpm/tss/tcg-2.... PS7, Line 426: response = tpm_process_command(TPM2_GetCapability, &cmd, &response_size);
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/vendor... File src/security/tpm/tss/vendor/cr50/cr50.c:
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/vendor... PS5, Line 23: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, &sub_command, NULL);
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/vendor... PS5, Line 46: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, command_body, NULL);
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/vendor... PS5, Line 62: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, &sub_command, NULL);
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/30826/5/src/security/tpm/tss/vendor... PS5, Line 79: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, &mode_command, NULL);
line over 80 characters
Done