Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35951 )
Change subject: nb/intel/nehalem: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35951/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35951/1//COMMIT_MSG@15
PS1, Line 15: is less forgiving for overflows.
I thought we fixed the stack usage with CB:26388?
Yes I briefly saw that, but didn't looked at how much was moved from stack to .bss. It looks like 0x1200 bytes we moved from stack to BSS, so I guess stack usage is sufficiently low to call it safe now. I'll update this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd7ceaa35db49e170bfb901bbff1c1a11223c63
Gerrit-Change-Number: 35951
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Oct 2019 14:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment