Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54901 )
Change subject: amdfwtool: Add a function to extract firmwares ......................................................................
Patch Set 7:
(6 comments)
File util/amdfwtool/extract.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120449): https://review.coreboot.org/c/coreboot/+/54901/comment/e3fc4f0c_4c4da536 PS7, Line 125: if ((token & 0xFF) == AMD_BIOS_BIN) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120449): https://review.coreboot.org/c/coreboot/+/54901/comment/424fc01d_b6437fb0 PS7, Line 138: if (token == AMD_BIOS_APOB) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120449): https://review.coreboot.org/c/coreboot/+/54901/comment/ac59d09f_85922267 PS7, Line 141: if (offset_module <= image_base) { printf("invalid offset"); trailing semicolon indicates no statements, indent implies otherwise
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120449): https://review.coreboot.org/c/coreboot/+/54901/comment/a2e9a588_c9b765d2 PS7, Line 141: if (offset_module <= image_base) { printf("invalid offset"); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120449): https://review.coreboot.org/c/coreboot/+/54901/comment/0a668a8b_5ba9560f PS7, Line 148: if (bhd_cookie == BDT1_COOKIE) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120449): https://review.coreboot.org/c/coreboot/+/54901/comment/cd44d9a9_314b2a1d PS7, Line 227: exit (1); space prohibited between function name and open parenthesis '('