Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47659 )
Change subject: soc/intel/common/fast_spi: Add custom boot media device
......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block...
File src/soc/intel/common/block/fast_spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block...
PS16, Line 20: (r
nit: space before (
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block...
PS16, Line 27: r
map *the* rest
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block...
PS16, Line 56: default n
I think it still needs the `bool` here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b564aed9809cf14b40a3b8e907622266fc782e2
Gerrit-Change-Number: 47659
Gerrit-PatchSet: 16
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Dec 2020 19:41:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment