Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44536 )
Change subject: mb/google/volteer: Implement weak function `cse_board_reset`
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44536/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44536/1/src/mainboard/google/voltee...
PS1, Line 17: if (!google_chromeec_ap_reset())
: halt();
Do we check the Cr50 version?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44536
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8ae21c203da218459d5fd30a23be23520ed0598
Gerrit-Change-Number: 44536
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 18 Aug 2020 01:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment