25 Feb
2019
25 Feb
'19
3:35 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31525 )
Change subject: mb/ocp/monolake: add TPM and IPMI support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31525/1/src/mainboard/ocp/monolake/romstage.... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/#/c/31525/1/src/mainboard/ocp/monolake/romstage.... PS1, Line 33: pci_write_config32(PCI_DEV(0, LPC_DEV, LPC_FUNC), LPC_GEN3_DEC,
To be perfectly honest I just copied them from UEFI system. […]
Please remove the unknown/unused entries. If really needed they can be added in a separate commit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31525
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f9fb17b9f1349272080e032991fe45a443a9d84
Gerrit-Change-Number: 31525
Gerrit-PatchSet: 1
Gerrit-Owner: Łukasz Siudut
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 Feb 2019 14:35:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Łukasz Siudut
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-MessageType: comment