Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63703 )
Change subject: soc/amd/sabrina: Disable lpc ldrq function
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/sabrina/include/soc/espi.h:
https://review.coreboot.org/c/coreboot/+/63703/comment/487af82d_7bbe1715
PS1, Line 6: define
Why move them? We don't need to make them public for others to consume.
Discussed offline, thought it may be useful to expose, but agreed it's YAGNI. It can be moved if/when needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I680c10dc8916c23ce6934d87aee5e484d4a84b78
Gerrit-Change-Number: 63703
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 21 Apr 2022 16:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment