Attention is currently required from: Zheng Bao, Fred Reitberger.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72456 )
Change subject: amdfwtool: Parse the line with SOC_NAME
......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/72456/comment/85e94b6c_555bfc60
PS2, Line 651: } else if (strcmp(&(oneline[match[1].rm_so]), "SOC_NAME") == 0) {
: /* TODO: Add back later */
: /* cb_config->soc_id =
: identify_platform(&(oneline[match[2].rm_so])); */
This else-if block should be added in CB:58552 since it is not necessary until then. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72456
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b8d7154d22db13675ff57b6abe61c747604c524
Gerrit-Change-Number: 72456
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 03 Feb 2023 02:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment