HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37378 )
Change subject: vendorcode/cavium/bdk/libdram: Add missing <stdlib.h> ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37378/6/src/vendorcode/cavium/bdk/l... File src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c:
https://review.coreboot.org/c/coreboot/+/37378/6/src/vendorcode/cavium/bdk/l... PS6, Line 1384: max(
max() probably does not belong into stdlib. […]
defined here "dram-util.h" but not useful..:
#if 0 /* FIXME(dhendrix): min/max are defined in stdlib.h */ /** * Standard min(a,b) macro */ #define min(X, Y) \ ({ typeof (X) __x = (X); \ typeof (Y) __y = (Y); \ (__x < __y) ? __x : __y; })
/** * Standard max(a,b) macro */ #define max(X, Y) \ ({ typeof (X) __x = (X); typeof(Y) __y = (Y); \ (__x > __y) ? __x : __y; }) #endif