Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36506 )
Change subject: mb/facebook/fbg1701: Add logo to the menu ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36506/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/36506/2/src/mainboard/facebook/fbg1... PS2, Line 73: default n
Why is this in the mainboard Kconfig, and not the chipset one?
The actual code to provide logo to the fsp is also in this directory. This is the only place where the config items are declared. This is the only board using this support so moving the complete support to the FSP 1.1 driver doesn't make a whole lot of sense.