Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48163 )
Change subject: lenovo/g505s: add the PIRQ routing table ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48163/1/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/48163/1/src/mainboard/lenovo/g505s/... PS1, Line 12: 0x1022, /* Vendor */ : 0x780b 1) Changed?
2) That's what getpir utility told me (0x1022 0x780b is 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus Controller [1022:780b] (rev 16)) . Meanwhile, a previously used " 0x1002 0x4384 device doesn't exist on this system at all
https://review.coreboot.org/c/coreboot/+/48163/1/src/mainboard/lenovo/g505s/... PS1, Line 60: copy_pirq_routing_table 1) Going from something dynamically generated to something static seems like a downgrade. 2) This [older] dynamic stuff never worked properly and seems to have a lot of dead code.