Martin Roth (martinroth@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12515
-gerrit
commit 66ac7f01b91311348904bcc820fb978394bcd345 Author: Martin Roth martinroth@google.com Date: Mon Nov 23 11:21:25 2015 -0700
iwave/IWRainBowG6: Fix IASL warning and remark
- Add an empty Operating Region for the empty _REG method - Serialize _CRS Method - Remove Kconfig default disabling IASL warnings as errors
Fixes IASL Warning: dsdt.aml 1362: Method (_REG, 2) Warning 3079 - ^ _REG has no corresponding Operation Region
Fixes IASL remark: dsdt.aml 1353: Method (_CRS, 0) Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within)
Change-Id: Iff01613a6e3238469c1fcb8d74f5e98d18420aaf Signed-off-by: Martin Roth martinroth@google.com --- src/mainboard/iwave/iWRainbowG6/Kconfig | 4 ---- src/mainboard/iwave/iWRainbowG6/acpi/ec.asl | 8 +++++++- 2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/mainboard/iwave/iWRainbowG6/Kconfig b/src/mainboard/iwave/iWRainbowG6/Kconfig index fbcfb17..5e92cfb 100644 --- a/src/mainboard/iwave/iWRainbowG6/Kconfig +++ b/src/mainboard/iwave/iWRainbowG6/Kconfig @@ -28,10 +28,6 @@ config IRQ_SLOT_COUNT int default 10
-# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - # This mainboard might have a higher clocked UART or might not be able to run # serial output at 115200 baud
diff --git a/src/mainboard/iwave/iWRainbowG6/acpi/ec.asl b/src/mainboard/iwave/iWRainbowG6/acpi/ec.asl index 1de2ef4..63abc00 100644 --- a/src/mainboard/iwave/iWRainbowG6/acpi/ec.asl +++ b/src/mainboard/iwave/iWRainbowG6/acpi/ec.asl @@ -19,7 +19,13 @@ Device(EC0) Name (_HID, EISAID("PNP0C09")) Name (_UID, 1)
- Method (_CRS, 0) + // _REG method requires that an operation region be defined. + OperationRegion (ERAM, EmbeddedControl, 0x00, 0xff) + Field (ERAM, ByteAcc, Lock, Preserve) + { + } + + Method (_CRS, 0, Serialized) { Name (ECMD, ResourceTemplate() {