Attention is currently required from: Patrick Rudolph, Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62014 )
Change subject: drivers/smmstore: Expose region device
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/62014/comment/1fc13cfb_7cda89bb
PS4, Line 67: lookup_store
No, as the name incoherent_rdev_init implies it's not cache coherent. Writes might not be seen as the old region content is still in cache.
yes reads are done mmapped and writes via SPI controller. Should we always use rw to simplify things? In SMM the SPI flash is not cached anyways so I don't think there really performance concerns (was the reason why we use incoherent rdev iirc).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6316b703829590bd6f41c3d4013b4a4660b9cbab
Gerrit-Change-Number: 62014
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 06 Apr 2022 09:34:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur.heymans@9elements.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment