HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... File src/mainboard/asus/p8z77-m_pro/acpi/ec.asl:
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... PS11, Line 4: Copyright Copyright for an empty file ?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... File src/mainboard/asus/p8z77-m_pro/acpi/superio.asl:
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/acpi... PS11, Line 4: Copyright ?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/roms... PS11, Line 19: #include <timestamp.h> is it needed ?
https://review.coreboot.org/#/c/33328/11/src/mainboard/asus/p8z77-m_pro/roms... PS11, Line 24: #include <console/console.h> used? please check the other includes