Attention is currently required from: Edward O'Callaghan. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63475 )
Change subject: cpu/x86/smm_module_loader.c: Rewrite setup more purely function ......................................................................
Patch Set 3:
(8 comments)
File src/cpu/x86/smm/smm_module_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/46e14af3_17f1c428 PS3, Line 468: const uintptr_t handler_base = ALIGN_DOWN(fx_save_area_base - handler_size, handler_alignment); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/235dd440_2c554d82 PS3, Line 469: printk(BIOS_DEBUG, "smihandler [0x%lx-0x%lx[\n", handler_base, handler_base + handler_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/1babc606_e66bd5ee PS3, Line 515: return smm_module_setup_stub(stub_segment_base, smram_size, params, (void *)fx_save_area_base); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/d7ec5634_e6dd9409 PS3, Line 561: const uintptr_t save_state_bottom = cpus[params->num_concurrent_save_states - 1].ss_start; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/c4811d73_ff907311 PS3, Line 569: printk(BIOS_ERR, "fxsave wont fit in smram\n"); 'wont' may be misspelled - perhaps 'won't'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/004b18bb_013fda90 PS3, Line 574: const size_t bottom_space = cpus[params->num_concurrent_save_states - 1].code_start - smm_stack_top; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/9c559de3_9e78919e PS3, Line 583: printk(BIOS_ERR, "handler wont fit in top of smram\n"); 'wont' may be misspelled - perhaps 'won't'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145820): https://review.coreboot.org/c/coreboot/+/63475/comment/fafda1b6_2575ab8b PS3, Line 590: printk(BIOS_ERR, "handler wont fit in bottom of smram\n"); 'wont' may be misspelled - perhaps 'won't'?