Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22215 )
Change subject: [WIP]nb/intel/sandybridge/raminit: Add ECC support
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/22215/4/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/22215/4/src/northbridge/intel/sandy...
PS4, Line 290:
Very minor nit: Remove the space before the punctuation.
Done
https://review.coreboot.org/c/coreboot/+/22215/4/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/22215/4/src/northbridge/intel/sandy...
PS4, Line 354: udelay(10);
Why?
not sure why, but i added a TODO comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/22215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1206746332c9939a78b67e7b48d3098bdef8a2ed
Gerrit-Change-Number: 22215
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Jan 2020 23:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-MessageType: comment