Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47173 )
Change subject: soc/intel/xeon_sp: Don't add memory resource twice
......................................................................
Patch Set 2:
(1 comment)
I updated the commit message. I hope it clarifies the change. The resource map is the same for all cpus. Don't add the same map multiple times.
https://review.coreboot.org/c/coreboot/+/47173/1/src/soc/intel/xeon_sp/uncor...
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/47173/1/src/soc/intel/xeon_sp/uncor...
PS1, Line 66: value |= (uint64_t)pci_read_config32(dev, entry->reg);
This looks like a hardware access to me.
ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia336f604441ae8d30b8418300da7c34ab9907cae
Gerrit-Change-Number: 47173
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 06 Nov 2020 01:05:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment