Attention is currently required from: Nico Huber, Tim Wawrzynczak, Christian Walter, Angel Pons, Arthur Heymans, EricR Lai.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59768 )
Change subject: drivers/i2c/tpm: Add override function for TPM I2C bus
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/i2c/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/59768/comment/7287131d_c3ac4abc
PS4, Line 22: int __weak get_tpm_i2c_bus(void)
: {
: return CONFIG_DRIVER_TPM_I2C_BUS;
: }
I don't think a weak function is a good solution here. You could have wrongly configured, by forgetting to provide a stong symbol and the compiler would not complain.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59768
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I658468ed3880de0a6b947c212fa8737956928c57
Gerrit-Change-Number: 59768
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 10:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment