Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit ......................................................................
Patch Set 11:
(4 comments)
Regarding the miniconfig file, if You have already configured coreboot for building You can create a miniconfig by executing `make savedefconfig`. It will generate a `defconfig` file in coreboot root directory which will contain only mainboard specific options. The `defconfig` miniconfig file can be restored to a full config by executing `make olddefconfig` which will fill all other configuration options making back a full config.
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/Kconfig File src/mainboard/portwell/m107/Kconfig:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/Kconfig... PS11, Line 30: choice These options are used anywhere? I suspect You would like to choose between correct SPDs based on BOM option read by GPIO. I would advise doing something similar like here: https://github.com/coreboot/coreboot/blob/master/src/mainboard/pcengines/apu... https://github.com/coreboot/coreboot/blob/master/src/mainboard/pcengines/apu... Just provide correct index to the function based on GPIO state and it will point to correct offset of spd.bin (either 0 or 256 bytes for Samsung and Micron respectively)
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/acpi/sup... File src/mainboard/portwell/m107/acpi/superio.asl:
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/acpi/sup... PS8, Line 21: Device (COM1) {
The board contains a ITE8528. […]
What I meant is why the ASL code is shifted by 1 TAB?
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/board_in... File src/mainboard/portwell/m107/board_info.txt:
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/board_in... PS8, Line 3: Category: misc
It is a Q7 module. […]
Here's more detailed description of board_info: https://github.com/coreboot/coreboot/tree/master/util/autoport#board_infotxt
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/com_ini... File src/mainboard/portwell/m107/com_init.c:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/com_ini... PS11, Line 24: void car_mainboard_pre_console_init(void) Since https://review.coreboot.org/c/coreboot/+/28464 is merged, You could rename the function to mainboard_after_memory_init