[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/acpi: Add provision to inject PCI PIRQ ACPI ma...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34658 )

Change subject: soc/intel/common/block/acpi: Add provision to inject PCI PIRQ ACPI mapping
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34658/6/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/34658/6/src/soc/intel/common/block/... 
PS6, Line 249: slot
You likely have multiple identical entries with the same int_pin, slot combo, which you should avoid to generate twice.

https://review.coreboot.org/c/coreboot/+/34658/6/src/soc/intel/common/block/... 
PS6, Line 289: #if CONFIG(SOC_INTEL_COMMON_ITSS_INTERRUPT_OVERRIDE)
Don't use preprocessor.