Attention is currently required from: Cliff Huang, Lance Zhao, Paul Menzel, Tim Wawrzynczak.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email )
Change subject: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82088/comment/7691b63a_1c297698 :
PS2, Line 7: acpi: Modify the order of increment operations
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/82088/comment/398ead77_2179f61c :
PS2, Line 11:
Please give more detail. The error was introduced in the commit making it public.
Done
https://review.coreboot.org/c/coreboot/+/82088/comment/ed3c8380_16242071 :
PS2, Line 13: TEST= Can get the correct index.
On what board did you test it?
Board=`nissa` project=`anraggar`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839
Gerrit-Change-Number: 82088
Gerrit-PatchSet: 3
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Fri, 26 Apr 2024 01:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment