14 Jan
2019
14 Jan
'19
1 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27586 )
Change subject: cpu/intel: Configure IA32_FEATURE_CONTROL for alternative SMRR ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/#/c/27586/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27586/26//COMMIT_MSG@14 PS26, Line 14: the possibility to not lock VMX
CONFIG_ENABLE_VMX is separate from CONFIG_SET_IA32_FC_LOCK_BIT. […]
If that bit must be set for those CPUs for SMRR to work, please do so. Otherwise we'd enable invalid configurations, no?
--
To view, visit https://review.coreboot.org/c/coreboot/+/27586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia85602e75385e24ebded75e6e6dd38ccc969a76b
Gerrit-Change-Number: 27586
Gerrit-PatchSet: 26
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 13:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment