Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47934 )
Change subject: security/intel/txt/ramstage.c: Fix clearing secrets on CBNT
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47934/6/src/security/intel/txt/rams...
File src/security/intel/txt/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47934/6/src/security/intel/txt/rams...
PS6, Line 95: * Assume all memory really was cleared.
It would be good to add that "Typically the memory was cleared by FSP-M".
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff4436501b84f5c209add845b3cd3a62782d17e6
Gerrit-Change-Number: 47934
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Dec 2020 08:47:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment