[coreboot-gerrit] [M] Change in coreboot[master]: acpi: Call acpi_fill_ssdt() only for enabled devices

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Karthik Ramasubramanian.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47148?usp=email )

Change subject: acpi: Call acpi_fill_ssdt() only for enabled devices
......................................................................

Patch Set 3:

(1 comment)

File src/drivers/intel/dptf/dptf.c:

https://review.coreboot.org/c/coreboot/+/47148/comment/c65c67d9_ec1c6e1c :
PS1, Line 235: if (!dev->enabled)
             : 		return;
             :
> the amd soc uart code expects the ssdt generation function to be called in all cases to be able to w […]

It feels wrong to do things on disabled devices though, doesn't it? Switching to using acpigen for the UART definition would solve that, or even just setting the raw ASL to have _STA set to the value of a Name which has a default value of 0, and then if it's enabled write one line of acpigen to set that Name to 1