hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 23:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 130: int swinf_no;
Can the number be signed?
Done
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 131: int mstid;
Should an id be unsigned?
Done
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 134: rdata
Why not just data?
Done
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 134: unsigned int
Please use void type.
Done
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 136: unsigned int addr, unsigned int wdata);
Ditto.
Done