Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38865 )
Change subject: nb/intel/sandybridge: Add Xeon E3-1200 (v1) hostbridge PCI ID
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
You probably want to re-upload this so that the build bot verifies it. While you're at it, there's a minor thing.
https://review.coreboot.org/c/coreboot/+/38865/2/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/38865/2/src/northbridge/intel/sandy...
PS2, Line 464:
That's a tab, should be a space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70187d09ecdaa8149299cdd8f6f8fc9517b05e15
Gerrit-Change-Number: 38865
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 18 Feb 2020 09:09:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment