Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46602 )
Change subject: mb/clevo/l140cu: Add vboot support ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46602/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46602/5//COMMIT_MSG@15 PS5, Line 15: the filenames look odd to me:
- vboot-ro is ok - vboot-roa should be vboot-ro-rwa - vboot-roab should be vboot-ro-rwab
if you don't agree, just mark as resolved
https://review.coreboot.org/c/coreboot/+/46602/5/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/fmds/vboot-roab.fmd:
https://review.coreboot.org/c/coreboot/+/46602/5/src/mainboard/clevo/cml-u/v... PS5, Line 33: COREBOOT(CBFS) 0xc00000-0x3df000-0x3df000-0x82000-0x4000-0x800-0x40-0x7c0-0xef000 = 0x2cc000 FW_MAIN_A(CBFS) and FW_MAIN_B(CBFS) are 0x3befc0
shouldn't they be equal?