Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/...
PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
Isn't this active high? What is the value of GPP_A8 when pen is inserted? and when is removed?
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/...
PS3, Line 33: PEN_EJECT
Can you please update the name to match the net name in schematics?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31815
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be
Gerrit-Change-Number: 31815
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 20 Mar 2019 04:24:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
