EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47640 )
Change subject: drivers/i2c: Add a driver for Semtech SX9324
......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
@Tim, would you take a look again? Thanks.
One of my main concerns with this patch is that it is currently not build-tested. If there's a board in the tree that will use this code, mind pushing a follow-up to this change to select this driver in its Kconfig, please?
Yes, will commit follow CL after this CL get merged. Still fine tune some registers for SAR. We verified this on Zork board with kernel v5.4 :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd582482728a2f535ed85f6696b2f5a4529ba421
Gerrit-Change-Number: 47640
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 08:58:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment