Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence
......................................................................
Patch Set 6:
(1 comment)
Is there a minimum power off time for the device?
https://review.coreboot.org/c/coreboot/+/47799/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47799/6//COMMIT_MSG@9
PS6, Line 9: According to Bayhub provided SPEC, 3.3V power need lead than PE_RST over 100ms.
suggestion:
```
According to the spec provided by Bayhub, the 3.3V power rail must be enabled at least 100ms before reset is released. To ensure this, set the power enable signal in the bootblock GPIO table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f
Gerrit-Change-Number: 47799
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Leo3 Chen
leo3.chen@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Dec 2020 17:41:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment