Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42423 )
Change subject: ACPI: Add framework for GNVS initialisation
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/Makefile.inc
File src/acpi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/Makefile.inc@11
PS4, Line 11: y
$(CONFIG_CHROMEOS)
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/chromeos-gnvs.c
File src/acpi/chromeos-gnvs.c:
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/chromeos-gnvs.c@18
PS4, Line 18: ACTIVE_ECFW_RO
Overwriting it with the current value tied a knot into my brain. Can we […]
Sounds good
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccad533c3824d70f6cbae52cc8dd79f142ece944
Gerrit-Change-Number: 42423
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 22:19:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
