Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38494 )
Change subject: drivers/net/r8168: Add SSDT Power Resource Methods
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38494/1/src/drivers/net/chip.h
File src/drivers/net/chip.h:
https://review.coreboot.org/c/coreboot/+/38494/1/src/drivers/net/chip.h@23
PS1, Line 23: /* Does the device have a power resource? */
Is clear from the variable name?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ae8dc30f45f55eec23f45e7b5fbc67a4542f87d
Gerrit-Change-Number: 38494
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jan 2020 11:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment