Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31063 )
Change subject: nb/intel/i945: Fix typo on DMIBAR32(0x334)
......................................................................
Patch Set 1:
lol
Well, it obviously is wrong. But after 10 years + of testing
why risk to break something?
Actually we don't know if the code is wrong or the absence of
a comment that would explain the intention. I first thought,
the comment above says that we write-back what we read, but
it doesn't go into that much detail.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib894c24bc787c6c211da26dca78bcd330ded6681
Gerrit-Change-Number: 31063
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Jan 2019 12:45:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment