Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43995 )
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
Patch Set 1:
(2 comments)
Thanks for pushing this change Lucas. There are some paths in devicetree/ACPI that need to be handled dynamically at runtime as well. Josie is currently working on adding some Kconfigs and helper functions to facilitate this.
https://review.coreboot.org/c/coreboot/+/43995/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/43995/1/src/mainboard/google/zork/v... PS1, Line 68: HP_INT_ODL_R There is some more work required here to ensure that devicetree exposes the correct irq_gpio depending upon the board id. Josie is working on adding Kconfig and some helper functions to take care of that.
https://review.coreboot.org/c/coreboot/+/43995/1/src/mainboard/google/zork/v... PS1, Line 115: HIGH This will have to be set to HIGH as part of ACPI power resources and hence here it will have to be set to LOW. This will require changes in all overridetrees as well.