build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40295 )
Change subject: soc/amd/common/psp: Add SmmInfo command ......................................................................
Patch Set 1:
(23 comments)
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/psp.h:
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 18: uint64_t address; /* Memory or IO address */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 19: uint32_t address_type; /* 0=I/O, 1=memory */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 20: uint32_t value_width; /* 0=byte, 1=word, 2=qword */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 21: uint32_t value_and_mask; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 22: uint32_t value_or_mask; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 26: uint64_t address; /* Memory or IO address */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 27: uint32_t address_type; /* 0=I/O, 1=memory */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 28: uint32_t value_width; /* 0=byte, 1=word, 2=qword */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 29: uint32_t reg_bit_mask; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 30: uint32_t expect_value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 34: struct smm_register smi_enb; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 35: struct smm_register eos; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 36: struct smm_register psp_smi_en; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/in... PS1, Line 37: struct smm_register reserved[5]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 335: printk (BIOS_ERR, "PSP: Error, cannot send SMM info from outside SMM\n"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/psp_def.h:
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 86: uint64_t smm_base; /* TSEG base */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 87: uint64_t smm_mask; /* TSEG mask */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 88: uint64_t psp_smm_data_region; /* PSP region in SMM space */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 89: uint64_t psp_smm_data_length; /* PSP region length in SMM space */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 90: struct smm_trigger_info smm_trig_info; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 92: struct smm_register_info smm_reg_info; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 94: uint64_t psp_mbox_smm_buffer_address; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 95: uint64_t psp_mbox_smm_flag_address; please, no spaces at the start of a line