Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 92: #define BUP_COMMON_GET_BOOT_PARTITION_INFO_CMD_REQ 0x1C : #define BUP_COMMON_SET_BOOT_PARTITION_CMD_REQ 0x1D can we move these commands IDs and ones above into a separate header file and refer it from there? Not sure if the list would keep growing with more CLs.
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 731: int unsigned int?
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 760: int same.
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 143: #define RO_BP1 0 : #define RW_BP2 1 : #define RW_BP3 2 can we have it as enum as well would help it bundle under Boot partition context or add comment here , as to what it implies to.
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 150: BP_STATUS_SUCCESS = 0, : BP_STATUS_GENERAL_FAILURE = 1, : BP_STATUS_PARTITION_NOT_PRESENT = 2, : BP_STATUS_HOST_REQUEST_FOR_PARTITION_SWITCH = 3, consistent spacing?