Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85228?usp=email )
Change subject: drivers/crb: Return an accurate status ......................................................................
drivers/crb: Return an accurate status
Rather than unconditionally returning that the device is present, return whether the fTPM is on or not.
Test=Boot the StarLite Mk V with the Intel ME disabled, and check that the TPM is reported as not present.
Change-Id: If8236021bf0e1264646971cff9c998fac99ac220 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/85228 Reviewed-by: Paul Menzel paulepanter@mailbox.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/drivers/crb/tis.c 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: Matt DeVillier: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/drivers/crb/tis.c b/src/drivers/crb/tis.c index df45125..0222f6d 100644 --- a/src/drivers/crb/tis.c +++ b/src/drivers/crb/tis.c @@ -90,7 +90,10 @@
acpi_device_write_uid(dev);
- acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + if (CONFIG(HAVE_INTEL_PTT) && ptt_active()) + acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + else + acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_OFF);
/* Resources */ acpigen_write_name("_CRS");