Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )
Change subject: amd/common/block/spi: Add EFS SPI configurations to Kconfig ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... File src/soc/amd/common/block/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... PS17, Line 15: range 0 7
Why are you looking to change the EM100 setting here? EM100 on zork support 2 and 4.
To keep it in sync with fch_spi_config_em100_modes: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... PS17, Line 33: range 0 5
This is only a zork limitation isn't it? I'm sure that other boards could support a faster speed sin […]
I was intending to keep it in sync with the implementation that existed in the spi driver to fch_spi_config_em100_modes(). Most devices I have worked on have required slower SPI speeds for em100, but all of them also had yoshi cables. So, probably it is not a problem for other boards. We can keep it in zork. I saw that it was being enabled for mandolin as well. Hence, the comment.