Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36431 )
Change subject: soc/intel/icelake: Remove redundant dependency check in cpu.c ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/cpu.c:
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... PS2, Line 23: if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED))
yes, i was thinking that, shouldn't we make that call implicit of any check as we know its SPI memor […]
I was noting that if you are going to make that argument about what icelake supports, etc, take the argument to the end. Add a comment at least to the assumptions one is making. I personally don't think the Kconfig checks are bad. If someone decides they want to combine things into common code that may be an issue as the same assumptions don't hold, but software can always be edited/changed.