31 Mar
2021
31 Mar
'21
6:51 a.m.
Attention is currently required from: Ravi kumar, Ravi Kumar Bokka, Julius Werner, mturney mturney. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support ......................................................................
Patch Set 45:
(2 comments)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/comment/5189401b_3c20a4da PS45, Line 1: Please remove the blank line at the top.
File src/mainboard/google/herobrine/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/45206/comment/552f4464_702738da PS45, Line 3: # TODO: update for Herobrine Where is the file copied from?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45206
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I428cf1a461ee63215f5683abbfed90202d1b2a88
Gerrit-Change-Number: 45206
Gerrit-PatchSet: 45
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 31 Mar 2021 06:51:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment